fix(network): zeroize bot-auth seed on drop and harden secret handling#1195
Open
fix(network): zeroize bot-auth seed on drop and harden secret handling#1195
Conversation
Use explicit Drop-based zeroization for BotAuthConfig seed bytes, keep Debug redaction, and add a regression test verifying seed bytes are wiped after drop. Update threat-model and request-signing specs for TM-CRY-001 and keep bot-auth feature wired to zeroize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Drop.Debugoutput redacted forBotAuthConfig.bot-authfeature wired tozeroize.Why
Issue #1177 requires explicit key-material hygiene: prevent long-lived secret exposure in memory and improve security-audit clarity around cryptographic material handling.
How
BotAuthConfignow holdsseed: [u8; 32]and callsseed.zeroize()inDrop.SigningKeyis reconstructed only at use sites (keyid, signing, public-key derivation).seed_zeroized_on_dropdebug_redacts_key_materialTM-CRYand mitigationTM-CRY-001Validation
cargo fmt --checkcargo test -p bashkit --features bot-auth network::bot_auth -- --nocapturecargo clippy -p bashkit --features bot-auth -- -D warningsjust pre-pr(known environment failure in bash comparison due missing host toolsbc/file, unrelated to this patch)Closes #1177.